chore/adopt-local-tree #4
2026-09-16
style: resolve the remaining ruff findings
Some checks failed
CI / lint (pull_request) Has been cancelled
CI / type (pull_request) Has been cancelled
CI / test-headless (macos-latest, 3.10) (pull_request) Has been cancelled
CI / test-headless (macos-latest, 3.11) (pull_request) Has been cancelled
CI / test-headless (macos-latest, 3.12) (pull_request) Has been cancelled
CI / test-headless (ubuntu-latest, 3.10) (pull_request) Has been cancelled
CI / test-headless (ubuntu-latest, 3.11) (pull_request) Has been cancelled
CI / test-headless (ubuntu-latest, 3.12) (pull_request) Has been cancelled
CI / test-headless (windows-latest, 3.10) (pull_request) Has been cancelled
CI / test-headless (windows-latest, 3.11) (pull_request) Has been cancelled
CI / test-headless (windows-latest, 3.12) (pull_request) Has been cancelled
CI / test-gui (pull_request) Has been cancelled
CI / test-integration (macos-latest) (pull_request) Has been cancelled
CI / test-integration (ubuntu-latest) (pull_request) Has been cancelled
CI / test-integration (windows-latest) (pull_request) Has been cancelled
Auto-fixes (UP037, UP038, F401, I001, SIM105, RUF100) plus hand-fixes: drop the now-unused `Union` imports, annotate mutable class attributes with ClassVar, raise ValidationError instead of blind Exception in the zero-length test, delete two dead locals, and bind the per-iteration grid-builder closures to their loop variables (B023).
chore: scope ruff ignores to tests, Qt and engineering notation
RUF001-003 are ignored repo-wide: × / ≈ / ² are deliberate in the engineering docs and formulas, which also makes the scattered inline noqa suppressions redundant. Tests use engineering symbols (A, I, L, E), `importorskip` before imports and capitalised test names; Qt requires camelCase signal names and PascalCase event overrides; OpenSees material fields (cR1, epsU) mirror the solver verbatim. N806 stays exempt only for the numeric modules that use L / Iz / Iy as symbols.
ci: split the workflow into lint/type/headless/gui/integration jobs
Reconstructs the workflow stripped during the tree copy to match the meta-gates: separate type job, headless command over tests/unit+tests/services, and dedicated GUI / integration jobs. Tool versions pinned to the pre-commit revisions (ruff 0.4.4, mypy 1.10.0) so CI and local hooks agree.
fix: ElasticSectionForm round-trips the SectionShape union
The form still passed flat b/h/d/tw/tf/diameter fields, which ElasticSection (extra='forbid') rejects, so reading any elastic section crashed. Rebuild the display-only hint as a PipeShape / AngleShape / RectShape member instead; an incomplete shape degrades to None rather than raising.
chore: adopt remaining local development state
Catch-all for the intermixed residue of the unpushed otko-development work ported into this tree: combinations/console-dock/quick-guide wiring across commands, core, services, views and tests; repo-wide ruff-format normalization; README/CONTRIBUTING updates; and the toolbar default (both toolbars now open in the top area, quick guide text updated). Splitting this further would require hunk-level surgery with low confidence; the preceding commits in this branch isolate the self-contained features.
feat: shared unit-aware formatting helpers
Pure presentation helpers (labels, number parse/format) shared by docks and dialogs; no Qt imports.
feat: load combinations
LoadCombination entity, combination service, manager dialog and unit/integration coverage.
test: relocate service-layer tests to tests/services/
Mirrors the source layout (core/services split) so unit/ holds core-only tests and services get their own home.
style: apply ruff format to generated catalog
Mechanical double-quote / line-wrap normalization over the schema-generated catalog classes; no semantic changes.
build: read version from _const.py, drop phantom scipy/pandas deps
Single source of truth for the package + pinned solver versions in src/otko/_const.py (hatch dynamic version). scipy/pandas were listed in [gui] but never imported. mypy strict mode rescoped to core/services/viewmodels; tomli added for tomllib-less Pythons.